Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out name inputs in user profile #1957

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Comment out name inputs in user profile #1957

merged 4 commits into from
Feb 21, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 17, 2022

closes #1956

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 17, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1957.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c876hlnh8vl50qmk2n60.

@render
Copy link

render bot commented Feb 17, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1957.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c876hm7h8vl50qmk2nag.

@render
Copy link

render bot commented Feb 17, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1957.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c876hmnh8vl50qmk2nn0.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 17, 2022
@Tbaut Tbaut enabled auto-merge (squash) February 17, 2022 19:01
asnaith
asnaith approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense to comment out the tests for now in case we re-introduce these inputs when we have a use case for the name data.

We could have used it.skip as an alternative for this too.

@Tbaut Tbaut merged commit 2696d9c into dev Feb 21, 2022
@Tbaut Tbaut deleted the mnt/tbaut-remove-name-1956 branch February 21, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove name and lastname input in display
4 participants
@Tbaut @asnaith @FSM1 @actions-user